opwvhk commented on code in PR #2672: URL: https://github.com/apache/avro/pull/2672#discussion_r1464582652
########## doc/content/en/docs/++version++/Specification/_index.md: ########## @@ -825,18 +825,28 @@ _Currently only available in Java and Rust_. Here, as scale property is stored in value itself it needs more bytes than preceding `decimal` type, but it allows more flexibility. ### UUID + The `uuid` logical type represents a random generated universally unique identifier (UUID). -A `uuid` logical type annotates an Avro `string`. The string has to conform with [RFC-4122](https://www.ietf.org/rfc/rfc4122.txt) +A `uuid` logical type annotates an Avro `string` or `fixed` of length 16. The string has to conform with [RFC-4122](https://www.ietf.org/rfc/rfc4122.txt) Review Comment: As RFC 4122 specifies both the string syntax as the byte layout, I propose this change: ```suggestion A `uuid` logical type annotates an Avro `string` or `fixed` of length 16. Both the string and `fixed` byte layout have to conform with [RFC-4122](https://www.ietf.org/rfc/rfc4122.txt). ``` A question though: as we're not specifying anything here, is it clear that there is no "explicit application or presentation protocol specification to the contrary" (as mentioned in the RFC, in [section 4.1.2](https://www.ietf.org/rfc/rfc4122.html#section-4.1.2)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
