ZENOTME commented on code in PR #2708:
URL: https://github.com/apache/avro/pull/2708#discussion_r1467183416
##########
lang/rust/avro/src/schema.rs:
##########
@@ -6551,7 +6568,12 @@ mod tests {
r#"{"field-id":"1","type":"map","values":"long"}"#,
&serialized
);
- assert_eq!(expected, Schema::parse_str(&serialized)?);
+ let actual_schema = Schema::parse_str(&serialized)?;
+ assert_eq!(expected, actual_schema);
+ assert_eq!(
Review Comment:
This may not be a good way to fix it. For PartialEq of schema, it will
compare `Canonical Form`. Can we add an interface to compare the whole schema?🤔
cc @martin-g
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
