[ 
https://issues.apache.org/jira/browse/AVRO-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ralf Grubenmann updated AVRO-3935:
----------------------------------
    Description: 
The schema compatibility check does not support logical types in the schema.

 

E.g. even comparing
{code:java}
{  
  "name":"test",
  "type":{
    "type":"int",
    "logicalType":"date"
  }
}{code}
{{with itself will fail compatibility check with an _Inconclusive_ 
compatibility error.}}

 

{{It'd be great if logical types could be supported.}}

 

{{I have a fix that adds support for most logical types from the docs available 
here: 
[https://github.com/Panaetius/avro/tree/add-rust-logical-type-compatibility]}}

{{This does not support custom logical types.}}

{{This does not support _Duration_ fixed type.}}

{{Note that this considers e.g. Int and Date to be compatible, the spec doesn't 
seem to define this properly but does mention that logical types are there to 
change a type without it being a breaking change, so I opted for making them 
compatible.}}

 

{{Linked PR: [https://github.com/apache/avro/pull/2728] }}

 

  was:
The schema compatibility check does not support logical types in the schema.

 

E.g. even comparing
{code:java}
{  
  "name":"test",
  "type":{
    "type":"int",
    "logicalType":"date"
  }
}{code}
{{with itself will fail compatibility check with an _Inconclusive_ 
compatibility error.}}

 

{{It'd be great if logical types could be supported.}}

 

{{I have a fix that adds support for most logical types from the docs available 
here: 
[https://github.com/Panaetius/avro/tree/add-rust-logical-type-compatibility]}}

{{This does not support custom logical types.}}

{{This does not support _Duration_ fixed type.}}

{{Note that this considers e.g. Int and Date to be compatible, the spec doesn't 
seem to define this properly but does mention that logical types are there to 
change a type without it being a breaking change, so I opted for making them 
compatible.}}

 

{{Let me know if this is ok and I can open a PR with my changes.}}

 


> Support logical types in Rust Schema Compatibility
> --------------------------------------------------
>
>                 Key: AVRO-3935
>                 URL: https://issues.apache.org/jira/browse/AVRO-3935
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: rust
>            Reporter: Ralf Grubenmann
>            Priority: Minor
>              Labels: pull-request-available, rust
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The schema compatibility check does not support logical types in the schema.
>  
> E.g. even comparing
> {code:java}
> {  
>   "name":"test",
>   "type":{
>     "type":"int",
>     "logicalType":"date"
>   }
> }{code}
> {{with itself will fail compatibility check with an _Inconclusive_ 
> compatibility error.}}
>  
> {{It'd be great if logical types could be supported.}}
>  
> {{I have a fix that adds support for most logical types from the docs 
> available here: 
> [https://github.com/Panaetius/avro/tree/add-rust-logical-type-compatibility]}}
> {{This does not support custom logical types.}}
> {{This does not support _Duration_ fixed type.}}
> {{Note that this considers e.g. Int and Date to be compatible, the spec 
> doesn't seem to define this properly but does mention that logical types are 
> there to change a type without it being a breaking change, so I opted for 
> making them compatible.}}
>  
> {{Linked PR: [https://github.com/apache/avro/pull/2728] }}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to