[
https://issues.apache.org/jira/browse/AVRO-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816905#comment-17816905
]
ASF subversion and git services commented on AVRO-3935:
-------------------------------------------------------
Commit 71faacb7170b1a4c32f04037d36aeec9c8a897af in avro's branch
refs/heads/branch-1.11 from Ralf Grubenmann
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=71faacb71 ]
AVRO-3935: Add support for compatibility check logical types in Rust Avro
(#2728)
* AVRO-3935: [Rust] add support for logical types in rust avro
* AVRO-3935: [Rust] Extract common logic for checking compatible reader/writer
types
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
---------
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Co-authored-by: Ralf Grubenmann <[email protected]>
Co-authored-by: Martin Tzvetanov Grigorov <[email protected]>
(cherry picked from commit 0733dd35defa9dca5124ecc36df3ac7b4e75a1d2)
> Support logical types in Rust Schema Compatibility checks
> ---------------------------------------------------------
>
> Key: AVRO-3935
> URL: https://issues.apache.org/jira/browse/AVRO-3935
> Project: Apache Avro
> Issue Type: Improvement
> Components: rust
> Reporter: Ralf Grubenmann
> Priority: Minor
> Labels: pull-request-available, rust
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The schema compatibility check does not support logical types in the schema.
>
> E.g. even comparing
> {code:java}
> {
> "name":"test",
> "type":{
> "type":"int",
> "logicalType":"date"
> }
> }{code}
> {{with itself will fail compatibility check with an _Inconclusive_
> compatibility error.}}
>
> {{It'd be great if logical types could be supported.}}
>
> {{I have a fix that adds support for most logical types from the docs
> available here:
> [https://github.com/Panaetius/avro/tree/add-rust-logical-type-compatibility]}}
> {{This does not support custom logical types.}}
> {{This does not support _Duration_ fixed type.}}
> {{Note that this considers e.g. Int and Date to be compatible, the spec
> doesn't seem to define this properly but does mention that logical types are
> there to change a type without it being a breaking change, so I opted for
> making them compatible.}}
>
> {{Linked PR: [https://github.com/apache/avro/pull/2728] }}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
