TomBruns commented on code in PR #2741:
URL: https://github.com/apache/avro/pull/2741#discussion_r1492772554
##########
lang/csharp/src/apache/main/Schema/Schema.cs:
##########
@@ -192,9 +192,14 @@ internal static Schema ParseJson(JToken jtok, SchemaNames
names, string encspace
return ArraySchema.NewInstance(jtok, props, names,
encspace);
if (type.Equals("map", StringComparison.Ordinal))
return MapSchema.NewInstance(jtok, props, names,
encspace);
- if (null != jo["logicalType"]) // logical type based on a
primitive
- return LogicalSchema.NewInstance(jtok, props, names,
encspace);
-
+ try
+ {
+ if (null != jo["logicalType"]) // logical type based
on a primitive
+ return LogicalSchema.NewInstance(jtok, props,
names, encspace);
+ }
+ // swallow exception from unknown logicalType
+ catch { }
+
Review Comment:
I will work on that, thanks for the feedback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
