mkmkme commented on code in PR #2756: URL: https://github.com/apache/avro/pull/2756#discussion_r1497069334
########## lang/c++/README: ########## @@ -39,8 +39,8 @@ mkdir build cd build cmake -G "Unix Makefiles" .. Review Comment: Not necessarily. This command will still work. But if I remove `-G "Unix Makefiles"` here, it might configure with `Ninja` build system. And this will make the `make` invocation` on the next line fail. I could, of course, replace it with `cmake --build build` instead, but it seems somewhat more verbose than a simple `make`. If needed, I can update it, of course :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
