TomBruns commented on code in PR #2751:
URL: https://github.com/apache/avro/pull/2751#discussion_r1499235509
##########
lang/csharp/src/apache/test/Schema/SchemaTests.cs:
##########
@@ -548,12 +549,79 @@ public void TestLogicalPrimitive(string s, string
baseType, string logicalType)
testToString(sc);
}
+ // Make sure unknown type is carried thru to LogicalTypeName
[TestCase("{\"type\": \"int\", \"logicalType\": \"unknown\"}",
"unknown")]
public void TestUnknownLogical(string s, string unknownType)
{
- var err = Assert.Throws<AvroTypeException>(() => Schema.Parse(s));
+ //var err = Assert.Throws<AvroTypeException>(() =>
Schema.Parse(s));
+ //Assert.AreEqual("Logical type '" + unknownType + "' is not
supported.", err.Message);
Review Comment:
they are not, those were the original lines that i replaced
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
