marcosschroh commented on code in PR #2774:
URL: https://github.com/apache/avro/pull/2774#discussion_r1508937952
##########
lang/rust/avro/src/schema_compatibility.rs:
##########
@@ -480,14 +421,7 @@ impl SchemaCompatibility {
);
}
SchemaKind::Duration => {
- if let Schema::Duration = writers_schema {
Review Comment:
The same reason as above. When enter the pattern `SchemaKind::Duration` is
does not make sense the `if let` because we know before hand that both types
are `Schema::Duration`, it can never raise an Error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
