thiru-mg commented on code in PR #2831: URL: https://github.com/apache/avro/pull/2831#discussion_r1547671738
########## lang/c++/impl/json/JsonIO.cc: ########## @@ -314,11 +314,37 @@ JsonParser::Token JsonParser::tryString() { } } +static string::const_iterator unicodeParse(string::const_iterator b, string::const_iterator e, uint32_t &n) { + string::const_iterator start = b; + for (int i = 0; i < 4; i++) { + ++b; + if (b == e) { + throw Exception(boost::format( + "Invalid unicode escape: %1%") % string(start, b)); Review Comment: Good catch. Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@avro.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org