henryf1991 commented on PR #2887: URL: https://github.com/apache/avro/pull/2887#issuecomment-2116024471
> 1. Use `@AvroName` for field names, and `@AvroTypeName` for the full type names (i.e., including namespace) > 2. Adjust `@AvroName` for fields and types, and `@AvroNamespace` for type namespaces > 3. Use `@AvroName` only, but add a special syntax like `my.namespace._` to override the namespace only > > The advantage of option 2 is that this sidesteps this entire discussion, but it also means there are 2 annotations to adjust the full type name. The latter is what will stay with us forever. > > The advantage of option 3 is that we don't have two annotations on full type names, but I'm not happy with the extra syntax. I prefer the option 2 where `@AvroNamespace` would let you only override the namespace only and can only be applied at class level. And use the existing `@AvroName ` annotation let you override the name only (no changes to be done for this as this is an existing functionality). I dont think option 3 works too well because `@AvroName` annotation can be applied on primitive types as well today and primitive types dont have a namespace attribute on their own. If we agree that option 2 is the best course of action to implement this feature, then the current code anyways does that today with the only difference being the name of the annotation is `@AvroTypeName` instead of `@AvroNamespace`. @opwvhk if thats fine I l just update the name to `@AvroNamespace` and the code in its current state does what is expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
