[ 
https://issues.apache.org/jira/browse/AVRO-2434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854446#comment-17854446
 ] 

José Joaquín Atria commented on AVRO-2434:
------------------------------------------

The line in Avro.pm was changed to "use 5.010_001" on 
[https://github.com/apache/avro/commit/eb21a2148b552d3df2db251558c7986ffb2bc833]
 as part of AVRO-2547.

As of 12/06/2024, the minimum version of Perl that the code requires is 5.10.1 
(which according to [cpan.rocks|https://cpan.rocks/] is the most common minimum 
required version):
{code:java}
$ perlver .


   ------------------------------------------------------------------  
 | file                                | explicit | syntax | external |
 | ------------------------------------------------------------------ |
 | Makefile.PL                         | ~        | ~      | n/a      |
 | share/interop-data-generate         | ~        | v5.6.0 | n/a      |
 | inc/Module/Install.pm               | v5.6.0   | v5.6.0 | n/a      |
 | inc/Module/Install/Repository.pm    | v5.5.0   | v5.6.0 | n/a      |
 | inc/Module/Install/Makefile.pm      | ~        | v5.5.0 | n/a      |
 | inc/Module/Install/ReadmeFromPod.pm | v5.6.0   | v5.6.0 | n/a      |
 | inc/Module/Install/MakeMaker.pm     | ~        | ~      | n/a      |
 | inc/Module/Install/Metadata.pm      | ~        | v5.5.0 | n/a      |
 | inc/Module/Install/Base.pm          | ~        | ~      | n/a      |
 | xt/schema.t                         | ~        | v5.6.0 | n/a      |
 | xt/interop.t                        | ~        | v5.6.0 | n/a      |
 | xt/pod.t                            | ~        | ~      | n/a      |
 | lib/Avro.pm                         | v5.10.1  | v5.6.0 | n/a      |
 | lib/Avro/DataFile.pm                | ~        | v5.6.0 | n/a      |
 | lib/Avro/Protocol.pm                | ~        | v5.6.0 | n/a      |
 | lib/Avro/DataFileWriter.pm          | ~        | v5.6.0 | n/a      |
 | lib/Avro/Schema.pm                  | ~        | v5.6.0 | n/a      |
 | lib/Avro/DataFileReader.pm          | ~        | v5.8.0 | n/a      |
 | lib/Avro/BinaryDecoder.pm           | ~        | v5.6.0 | n/a      |
 | lib/Avro/BinaryEncoder.pm           | ~        | v5.6.0 | n/a      |
 | lib/Avro/Protocol/Message.pm        | ~        | v5.6.0 | n/a      |
 | bin/avro-to-json                    | ~        | v5.6.0 | n/a      |
 | t/04_datafile.t                     | ~        | v5.6.0 | n/a      |
 | t/01_schema.t                       | ~        | v5.6.0 | n/a      |
 | t/05_protocol.t                     | ~        | v5.6.0 | n/a      |
 | t/00_compile.t                      | ~        | ~      | n/a      |
 | t/03_bin_decode.t                   | ~        | v5.6.0 | n/a      |
 | t/02_bin_encode.t                   | ~        | v5.6.0 | n/a      |
 | t/01_names.t                        | ~        | v5.6.0 | n/a      |
 | ------------------------------------------------------------------ |
 | Minimum explicit version : v5.10.1                                 |
 | Minimum syntax version   : v5.8.0                                  |
 | Minimum version of perl  : v5.10.1                                 |
   ------------------------------------------------------------------  
{code}
Note that that is not necessarily the same as the minimum version of Perl that 
Apache is willing to commit to support.

FWIW, the version in BUILD.md comes from AVRO-2238 where it seems to have been 
changed accidentally. Maybe [~Fokko] remembers how/why that happened?

If we can get away with moving to 5.24 then there are all sorts of nice modern 
goodies we can start using, like Object::Pad and Feature::Compat::Try.

> Make the supported Perl version consistent
> ------------------------------------------
>
>                 Key: AVRO-2434
>                 URL: https://issues.apache.org/jira/browse/AVRO-2434
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: perl
>            Reporter: Kengo Seki
>            Priority: Major
>
> According to BUILD.md, the supported Perl version seems to be 5.24.1+, while 
> Avro.pm says 5.8.1+.
> {code:title=BUILD.md}
> The following packages must be installed before Avro can be built:
> (snip)
>  - Perl: Perl 5.24.1 or greater, gmake, Module::Install,
> {code}
> {code:title=lang/perl/lib/Avro.pm}
> use 5.008_001;
> {code}
> Which version is the right one? If the former is, we should simply update 
> Avro.pm too.
> If the latter is, we should update BUILD.md and Dockerfile to use Perl 5.8.1 
> for building and testing.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to