Gerrit0 commented on code in PR #2966:
URL: https://github.com/apache/avro/pull/2966#discussion_r1677716799
##########
lang/c++/include/avro/buffer/BufferStreambuf.hh:
##########
@@ -135,7 +135,11 @@ protected:
memcpy(c, gptr(), toCopy);
c += toCopy;
bytesCopied += toCopy;
- gbump(toCopy);
+ while (toCopy > INT_MAX) {
Review Comment:
I did that first, switched to the macro when gcc 9.4 on the ARM agent was
complaining about signedness... I can add a `static_cast` instead, hopefully
newer compilers don't flag that as a useless cast.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
