KalleOlaviNiemitalo commented on code in PR #3053:
URL: https://github.com/apache/avro/pull/3053#discussion_r1696803127
##########
lang/c++/impl/Node.cc:
##########
@@ -189,6 +190,18 @@ void Node::setLogicalType(LogicalType logicalType) {
"LONG type");
}
break;
+ case LogicalType::LOCAL_TIMESTAMP_MILLIS:
+ if (type_ != AVRO_LONG) {
+ throw Exception("LOCAL_TIMESTAMP-MILLIS logical type can only
annotate "
+ "LONG type");
+ }
+ break;
+ case LogicalType::LOCAL_TIMESTAMP_MICROS:
+ if (type_ != AVRO_LONG) {
+ throw Exception("LOCAL_TIMESTAMP-MICROS logical type can only
annotate "
+ "LONG type");
Review Comment:
```suggestion
throw Exception("LOCAL-TIMESTAMP-MICROS logical type can
only annotate "
"LONG type");
```
##########
lang/c++/impl/Node.cc:
##########
@@ -189,6 +190,18 @@ void Node::setLogicalType(LogicalType logicalType) {
"LONG type");
}
break;
+ case LogicalType::LOCAL_TIMESTAMP_MILLIS:
+ if (type_ != AVRO_LONG) {
+ throw Exception("LOCAL_TIMESTAMP-MILLIS logical type can only
annotate "
+ "LONG type");
Review Comment:
```suggestion
throw Exception("LOCAL-TIMESTAMP-MILLIS logical type can
only annotate "
"LONG type");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
