[
https://issues.apache.org/jira/browse/AVRO-4031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874228#comment-17874228
]
ASF subversion and git services commented on AVRO-4031:
-------------------------------------------------------
Commit 14361c0b396e716efcb84781a3b52d660d57a4bd in avro's branch
refs/heads/dependabot/maven/lang/java/org.apache.commons-commons-lang3-3.16.0
from MarcoLugo
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=14361c0b3 ]
AVRO-4031: [Rust] builder header (#3096)
* AVRO-4031: [Rust] allow setting has_header in builder
* AVRO-4031: [Rust] add test for appending with multiple writers
* AVRO-4031: [Rust] Prefix the new IT test name with `avro_4031_`
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
---------
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Co-authored-by: Martin Tzvetanov Grigorov <[email protected]>
> Writer::append_to_with_codec cannot take block_size so it falls back to
> default even if original Writer had a different size
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: AVRO-4031
> URL: https://issues.apache.org/jira/browse/AVRO-4031
> Project: Apache Avro
> Issue Type: Improvement
> Components: rust
> Reporter: Marco Lugo
> Assignee: Marco Lugo
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.18.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Writer::append_to_with_codec is great to continue a writer but it can be
> inconsistent with the original writer in terms of block_size. If the original
> writer used a custom block_size then this new writer will fall back to
> DEFAULT_BLOCK_SIZE. This can be important when considering compression among
> other things.
>
> I am not sure what the proper API should be here:
> - Change append_to_with_codec's signature ro reflect this, which would be a
> breaking change;
> - Add a new method, something like append_to_with_codec_and_block_size, but
> this does not feel very future proof;
> - Allow the Writer builder to set has_header to true. If I'm understanding
> this correctly, this would be future proof and would not break backwards
> compatibility;
> - Other?
>
> From the little context I have, I would be inclined to choose the 3rd option.
>
> What would be the preferred option, if any? I'd be happy to open a PR once
> there is consensus on the way forward.
> Thank you,
> Marco
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
