pascalginter commented on code in PR #3167:
URL: https://github.com/apache/avro/pull/3167#discussion_r1770841955
##########
lang/c++/test/SchemaTests.cc:
##########
@@ -315,11 +436,13 @@ static void testRoundTrip(const char *schema) {
compiledSchema.toJson(os);
std::string result = os.str();
result.erase(std::remove_if(result.begin(), result.end(), ::isspace),
result.end()); // Remove whitespace
- BOOST_CHECK(result == std::string(schema));
+ std::string trimmedSchema = schema;
+ trimmedSchema.erase(std::remove_if(trimmedSchema.begin(),
trimmedSchema.end(), ::isspace), trimmedSchema.end());
Review Comment:
Thanks for pointing this out, I was not aware of the issues with std::isspace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
