pascalginter commented on code in PR #3168:
URL: https://github.com/apache/avro/pull/3168#discussion_r1773270767
##########
lang/c++/test/SchemaTests.cc:
##########
@@ -355,7 +355,8 @@ const char *roundTripSchemas[] = {
{"name":"f1","type":"long","extra_field":"1"},
{"name":"f2","type":"int","extra_field1":"21","extra_field2":"22"}
]
- })"
+ })",
+ R"({"type":"array","items":"long","extra":"1"})"
Review Comment:
The issue is not in the added test case but in an existing test case (line
146) in testBasic checking that custom attributes do not impact the ability to
compile schemas.
The specified attribute in the test was given as a integer, which so far was
no issue as it was ignored but now it is attempted to be parsed. This attempt
failed as only strings are supported in custom attributes. For now I changed
the attribute to a string, the original test case can be restored once
non-string attributes are supported.
(This change of 1 to "1" was present in the original PR, I accidentally
undid it when merging the latest main)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
