KalleOlaviNiemitalo commented on code in PR #3209:
URL: https://github.com/apache/avro/pull/3209#discussion_r1792879041
##########
lang/csharp/src/apache/main/IO/JsonDecoder.cs:
##########
@@ -45,6 +45,14 @@ private class ReorderBuffer
public JsonReader OrigParser { get; set; }
}
+ private class AvroJsonTextReader : JsonTextReader
Review Comment:
Could make the class `sealed` as well; that might help inlining in the JIT
compiler. Alas, it looks like `private JsonReader reader;` cannot be changed
to `private AvroJsonTextReader reader;` because DoAction assigns a
JsonElementReader there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
