KalleOlaviNiemitalo commented on code in PR #3231:
URL: https://github.com/apache/avro/pull/3231#discussion_r1823784488
##########
lang/csharp/versions.props:
##########
@@ -58,15 +58,15 @@
Please sort the packages alphabetically
-->
<PropertyGroup Label="Build, Test, Code Analysis, Benchmark Package
Versions">
- <BenchmarkDotNetVersion>0.13.10</BenchmarkDotNetVersion>
- <CoverletCollectorVersion>6.0.0</CoverletCollectorVersion>
- <CoverletMSBuildVersion>6.0.0</CoverletMSBuildVersion>
- <MicrosoftBuildFrameworkVersion>17.8.3</MicrosoftBuildFrameworkVersion>
-
<MicrosoftBuildUtilitiesCoreVersion>17.8.3</MicrosoftBuildUtilitiesCoreVersion>
- <MicrosoftCodeAnalysisVersion>4.7.0</MicrosoftCodeAnalysisVersion>
-
<MicrosoftCodeAnalysisCSharpVersion>4.7.0</MicrosoftCodeAnalysisCSharpVersion>
-
<MicrosoftCodeAnalysisCSharpCodeStyleVersion>4.7.0</MicrosoftCodeAnalysisCSharpCodeStyleVersion>
-
<MicrosoftCodeAnalysisNetAnalyzersVersion>8.0.0</MicrosoftCodeAnalysisNetAnalyzersVersion>
+ <BenchmarkDotNetVersion>0.14.0</BenchmarkDotNetVersion>
+ <CoverletCollectorVersion>6.0.2</CoverletCollectorVersion>
+ <CoverletMSBuildVersion>6.0.2</CoverletMSBuildVersion>
+ <MicrosoftBuildFrameworkVersion>17.12.6</MicrosoftBuildFrameworkVersion>
+
<MicrosoftBuildUtilitiesCoreVersion>17.12.6</MicrosoftBuildUtilitiesCoreVersion>
Review Comment:
If Avro.MSBuild is not being published in a NuGet package, then I suppose
the version changes are fine and the project is OK to delete altogether.
If it were so published, then I'd prefer requiring only 15.something
versions of MSBuild, for Visual Studio 2017 compatibility as per [Choose the
MSBuild API version to reference
](https://learn.microsoft.com/en-us/visualstudio/msbuild/tutorial-custom-task-code-generation#choose-the-msbuild-api-version-to-reference).
As I understand it, the main difficulties with running complex code in an
MSBuild task are assembly version conflicts and NuGet packaging. And the
benefits are support for more complex output parameters (multiple properties,
and items with metadata, for subsequent processing in MSBuild) and better
integration with the MSBuild logging system (verbosity settings and HelpLink,
which MSBuild itself cannot parse from stdout/stderr streams).
There seems to be some progress towards making custom MSBuild tasks easier
to create and package: <https://github.com/dotnet/msbuild/issues/10733>.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
