rayokota commented on PR #3242: URL: https://github.com/apache/avro/pull/3242#issuecomment-2485025556
Thanks for the review @martin-g and @KalleOlaviNiemitalo ! I've incorporated your review feedback. @KalleOlaviNiemitalo , I've renamed the existing method as `ParseInternal` as you suggested, and added a public method that calls it after performing argument null checks and json trimming. Yes, I plan to use this method in https://github.com/confluentinc/confluent-kafka-dotnet , since Confluent Schema Registry supports Avro schemas that can reference other schemas by name. This allows schema reuse, as well as allows our customers to decompose very Avro large schemas into smaller ones. As suggested, I've added an example of how I intend to use this method. The test has a root schema that refers to a nested schema by name only. In Confluent Schema Registry we also store some metadata with the root schema to indicate which schema(s) it refers to. The Schema Registry client in https://github.com/confluentinc/confluent-kafka-dotnet will retrieve both schemas independently, and then use the method in this PR to reconstruct the root schema. I've implemented this functionality for Schema Registry clients written in Java, go, Python, and Node.js, since the Avro libraries in those other languages also provide a means to compose schemas by name. This PR will allow C# to provide the same capability. Please let me know if you would like me to add anything else to my explanation or this PR. Thanks in advance! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
