CalvinKirs commented on PR #3245: URL: https://github.com/apache/avro/pull/3245#issuecomment-2490081227
> `lang/csharp/src/apache/codegen/Avro.codegen.csproj` is the C# project file for the Apache.Avro.Tools NuGet package. It gets the `Newtonsoft.Json.dll` files from the Newtonsoft.Json NuGet package, instead of building them from source.↳ > > The changes in this pull request look all right to me, but it might be appropriate to also remove the Castle Core and log4net notices from `lang/csharp/LICENSE`, if Avro no longer references those libraries.↳ > > In contrast, the Newtonsoft.Json notices should not be removed from `lang/csharp/LICENSE`. And this PR does not remove them. This tool is something we released? It seems to lack a NOTICE file, and the binary distribution still needs to comply with the AL2 requirements. I'm not familiar with C#, so I'm unable to determine whether the LICENSE file is correct, specifically if it includes the licenses for the bundled components. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
