martin-g commented on code in PR #66:
URL: https://github.com/apache/avro-rs/pull/66#discussion_r1880289176
##########
avro/src/schema.rs:
##########
@@ -3238,7 +3304,7 @@ mod tests {
assert_eq!(schema, expected);
let canonical_form = &schema.canonical_form();
- let expected =
r#"{"name":"record","type":"record","fields":[{"name":"enum","type":{"name":"enum","type":"enum","symbols":["one","two","three"]}},{"name":"next","type":{"name":"enum","type":"enum","symbols":["one","two","three"]}}]}"#;
+ let expected =
r#"{"name":"record","type":"record","fields":[{"name":"enum","type":{"name":"enum","type":"enum","symbols":["one","two","three"]}},{"name":"next","type":"enum"}]}"#;
Review Comment:
What happened with the symbols of `"name":"next"` ?
##########
avro/src/schema.rs:
##########
@@ -3322,7 +3388,7 @@ mod tests {
assert_eq!(schema, expected);
let canonical_form = &schema.canonical_form();
- let expected =
r#"{"name":"record","type":"record","fields":[{"name":"fixed","type":{"name":"fixed","type":"fixed","size":456}},{"name":"next","type":{"name":"fixed","type":"fixed","size":456}}]}"#;
+ let expected =
r#"{"name":"record","type":"record","fields":[{"name":"fixed","type":{"name":"fixed","type":"fixed","size":456}},{"name":"next","type":"fixed"}]}"#;
Review Comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@avro.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
