jhump commented on PR #3069: URL: https://github.com/apache/avro/pull/3069#issuecomment-2548955396
@martin-g, I would happily see @jmd-z's change (this PR) merge, since he put the effort into it first. @jmd-z, do you plan to make these changes? It's been a few months since your last comment. In the meantime, since we cannot push a commit to their branch to help push this forward, I have made changes in my own branch. Perhaps my PR (#3266) could be considered as an alternative if we don't hear back from @jmd-z? It deprecates all of the old string-only methods (`addAttribute`, `getAttribute`, and `attributes`) and introduces alternatives where the value is JSON-encoded and string values must be quoted and escaped (`addAttributeJson`, `getAttributeJson`, and `jsonAttributes`). It is, obviously, very similar to the change here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
