KalleOlaviNiemitalo commented on code in PR #3175:
URL: https://github.com/apache/avro/pull/3175#discussion_r1899081928
##########
lang/java/avro/src/test/java/org/apache/avro/util/TestUtf8.java:
##########
@@ -99,6 +99,26 @@ void hashCodeReused() {
assertEquals(4122302, u.hashCode());
}
+ /**
+ * There are two different code paths that hashcode() can call depending on
the
+ * state of the internal buffer. If the buffer is full (string length eq.
buffer
+ * length) then the JDK hashcode function can be used. This function can is
+ * vectorized JDK 21+ and therefore should be preferable. However, if the
buffer
+ * is not full (string length le. buffer length), then the JDK does not
support
Review Comment:
"<del>hashcode</del><ins>hashCode</ins>" (twice)
"function can <del>is</del><ins>be</ins> vectorized <ins>in</ins> JDK 21+"
The "eq." and "le." abbreviations look confusing. Does "le." mean "less
than or equal to"? But the equality case was already described.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
