mkmkme commented on code in PR #3299:
URL: https://github.com/apache/avro/pull/3299#discussion_r1926920962
##########
lang/c++/CMakeLists.txt:
##########
@@ -264,3 +266,28 @@ if (NOT CMAKE_BUILD_TYPE)
"Choose the type of build, options are: None Debug Release
RelWithDebInfo MinSizeRel."
FORCE)
endif (NOT CMAKE_BUILD_TYPE)
+
+include(CMakePackageConfigHelpers)
+
+write_basic_package_version_file(
+ "${CMAKE_CURRENT_BINARY_DIR}/AvroConfigVersion.cmake"
+ VERSION ${AVRO_VERSION}
+ COMPATIBILITY SameMajorVersion)
+
+configure_package_config_file(
+ "${CMAKE_CURRENT_SOURCE_DIR}/cmake/AvroConfig.cmake.in"
+ "${CMAKE_CURRENT_BINARY_DIR}/AvroConfig.cmake"
+ INSTALL_DESTINATION lib/cmake/Avro
Review Comment:
I see an inconsistency here. The headers are installed in `include/avro`
while cmake files are in `lib/cmake/Avro`. Maybe it should be `lib/cmake/avro`
instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@avro.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
