jhump commented on code in PR #3266:
URL: https://github.com/apache/avro/pull/3266#discussion_r1929246242
##########
lang/c++/test/unittest.cc:
##########
@@ -489,12 +491,26 @@ struct TestSchema {
expectedJsonWithoutCustomAttribute);
}
- void checkCustomAttributes_getAttribute() {
- CustomAttributes cf;
- cf.addAttribute("field1", std::string("1"));
+ void checkCustomAttributes_addAndGetAttributeJson() {
Review Comment:
I think the only thing missing from the matrix was the failure tests for
passing a "string" value mode style value when mode is actually "json" and vice
versa.
I updated the tests in e95f691, and they caught an issue: we were only
handling `TooManyExceptions` when value mode was "string", but it could be
triggered in either value mode. So I've fixed that in the same commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@avro.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
