martin-g commented on code in PR #3303: URL: https://github.com/apache/avro/pull/3303#discussion_r1946161319
########## lang/php/lib/AvroVarint.php: ########## @@ -0,0 +1,63 @@ +<?php + +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +namespace Apache\Avro; + +/** + * Varint encoding/decoding for 64bit php + * + * @package Avro + */ +class AvroVarint +{ + public static function encodeLong(int $n): string Review Comment: IMO it would be good to add some documentation for the new public methods in this class. The old methods (in AvroIOBinaryDecoder have at least `@param`, `@returns`, etc. Also in the other SDKs the unit tests are associated with the class they test. Here we don't have **any** tests. There are tests in DatumIOTest but it will be harder/confusing for the next contributor to make the connection. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@avro.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
