jdarais commented on PR #139: URL: https://github.com/apache/avro-rs/pull/139#issuecomment-2716825224
> I wonder whether SchemaAwareSerializer is a better name ?! Yeah it did cross my mind that the `DirectSerializer` using a schema to serialize the input is one of its distinguishing features, though I think it's also a distinguishing feature that it serializes directly to a `Write` stream, since the other `ser::Serializer` implementation "serializes" to a `Value`, not a `Write` stream. That second distinguishing feature is what led me to the name `DirectSerializer`, though I realize that it's ambiguous what the "Direct" in the name is referring two. Perhaps `WriteSerializer` would be a better name for that purpose. Or `SchemaAwareWriteSerializer`? (Another possibility for indicating usage of a schema would be `SchemaBased`.) I'm not too opinionated on the name, though, just throwing out ideas. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
