mkeskells commented on code in PR #3307: URL: https://github.com/apache/avro/pull/3307#discussion_r1993721954
########## lang/java/avro/src/test/java/org/apache/avro/generic/GenericDataTest.java: ########## @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.avro.generic; + +import org.apache.avro.Conversion; +import org.apache.avro.LogicalType; +import org.apache.avro.Schema; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.Arguments; +import org.junit.jupiter.params.provider.MethodSource; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.Collections; +import java.util.EnumMap; +import java.util.List; +import java.util.Map; + +import java.util.stream.Stream; + +import static org.junit.jupiter.api.Assertions.*; + +class GenericDataTest { + + static Schema createSchema(Schema.Type type) { + switch (type) { + case FIXED: + return Schema.createFixed("foo", null, null, 4); + case UNION: + return Schema.createUnion(Schema.create(Schema.Type.FLOAT), Schema.create(Schema.Type.STRING)); + case MAP: + return Schema.createMap(Schema.create(Schema.Type.FLOAT)); + case ARRAY: + return Schema.createArray(Schema.create(Schema.Type.STRING)); + case RECORD: + return Schema.createRecord("record", null, null, false); + case ENUM: + return Schema.createEnum("myEnum", null, null, Collections.emptyList()); + default: + return Schema.create(type); + } + } + + static Object sampleValue(Schema schema) { + if (schema.getLogicalType() != null) { + return new Object(); + } + switch (schema.getElementType().getType()) { + case BOOLEAN: + return true; + case INT: + return Integer.MAX_VALUE; + case LONG: + return Long.MAX_VALUE; + case FLOAT: + return Float.MAX_VALUE; + case DOUBLE: + return Double.MAX_VALUE; + default: + return "foo"; + } + } + + static Schema createArraySchema(Schema.Type type) { + return Schema.createArray(createSchema(type)); + } + + static Schema createArraySchemaWithLogicalType(Schema.Type type) { + final LogicalType logicalType = new LogicalType("Mike"); + Schema schema = logicalType.addToSchema(createSchema(type)); + return Schema.createArray(schema); + } + + static Map<Schema.Type, GenericData.AbstractArray<?>> validMappings = new EnumMap<>(Schema.Type.class); + static { + for (Schema.Type type : Schema.Type.values()) { + switch (type) { + case INT: + validMappings.put(type, new PrimitivesArrays.IntArray(0, createArraySchema(type))); + break; + case LONG: + validMappings.put(type, new PrimitivesArrays.LongArray(0, createArraySchema(type))); + break; + case DOUBLE: + validMappings.put(type, new PrimitivesArrays.DoubleArray(0, createArraySchema(type))); + break; + case FLOAT: + validMappings.put(type, new PrimitivesArrays.FloatArray(0, createArraySchema(type))); + break; + case BOOLEAN: + validMappings.put(type, new PrimitivesArrays.BooleanArray(0, createArraySchema(type))); + break; + default: + validMappings.put(type, new GenericData.Array<>(0, createArraySchema(type))); + break; + } + } + } + + public static Stream<Arguments> testNewArrayData() { + + List<Arguments> data = new ArrayList<>(); + + validMappings.forEach((validKey, optimalValue) -> { + Class<?> optimalValueType = optimalValue.getClass(); + // cant reuse null, or a string + final Schema arraySchema = createArraySchema(validKey); + + data.add(Arguments.of("null input, " + validKey, arraySchema, Collections.emptyList(), null, optimalValueType)); + data.add( + Arguments.of("String input, " + validKey, arraySchema, Collections.emptyList(), "foo", optimalValueType)); + // should reuse arraylist & generic array + data.add(Arguments.of("ArrayList input, " + validKey, arraySchema, Collections.emptyList(), new ArrayList<>(), + ArrayList.class)); + data.add(Arguments.of("Generic input, " + validKey, arraySchema, Collections.emptyList(), + new GenericData.Array<Object>(0, arraySchema), GenericData.Array.class)); + // with logical type + if (validKey != Schema.Type.UNION) { + data.add(Arguments.of("null (with logical type) input, " + validKey, createArraySchemaWithLogicalType(validKey), + Collections.emptyList(), null, GenericData.Array.class)); + data.add(Arguments.of("String (with logical type) input, " + validKey, + createArraySchemaWithLogicalType(validKey), Collections.emptyList(), "foo", GenericData.Array.class)); + data.add(Arguments.of("ArrayList (with logical type) input, " + validKey, arraySchema, Collections.emptyList(), + new ArrayList<>(), ArrayList.class)); + data.add(Arguments.of("Generic (with logical type) input, " + validKey, arraySchema, Collections.emptyList(), + new GenericData.Array<Object>(0, arraySchema), GenericData.Array.class)); +// with logical type and conversion + + validMappings.forEach((targetKey, targetType) -> { + if (targetKey != Schema.Type.UNION) { + data.add(Arguments.of("null (with logical type) input, " + validKey + " convert to " + targetType, + createArraySchemaWithLogicalType(targetKey), singleConversion(targetKey), null, targetType.getClass())); + data.add(Arguments.of("String (with logical type) input, " + validKey + " convert to " + targetType, + createArraySchemaWithLogicalType(targetKey), singleConversion(targetKey), "foo", + targetType.getClass())); + data.add(Arguments.of("ArrayList (with logical type) input, " + validKey + " convert to " + targetType, + createArraySchemaWithLogicalType(targetKey), singleConversion(targetKey), new ArrayList<>(), + ArrayList.class)); + data.add(Arguments.of("Generic (with logical type) input, " + validKey, arraySchema, + Collections.emptyList(), new GenericData.Array<Object>(0, arraySchema), GenericData.Array.class)); + } + }); + + } + + validMappings.forEach((suppliedValueType, suppliedValue) -> { + data.add(Arguments.of(suppliedValueType + " input " + validKey, arraySchema, Collections.emptyList(), + suppliedValue, optimalValueType)); + if (validKey != Schema.Type.UNION) + data.add(Arguments.of(suppliedValueType + " (with logical type) input " + validKey, + createArraySchemaWithLogicalType(validKey), Collections.emptyList(), suppliedValue, + GenericData.Array.class)); + }); + }); + return data.stream(); + } + + private static <T> List<Conversion<?>> singleConversion(Schema.Type targetKey) { + return Collections.singletonList(new Conversion<T>() { + + public Class<T> getConvertedType() { Review Comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
