Shnatsel commented on code in PR #169:
URL: https://github.com/apache/avro-rs/pull/169#discussion_r2022136374
##########
avro/src/error.rs:
##########
@@ -377,6 +377,8 @@ pub enum Error {
#[error("Failed to compress with flate: {0}")]
DeflateCompress(#[source] std::io::Error),
+ // no longer possible after migration from libflate to miniz_oxide
+ // TODO: remove in the next semver-breaking release
Review Comment:
Done. I see the version in git is 0.18, while the latest version on
crates.io is 0.17. That is a semver-incompatible version bump. Should I go
ahead and remove the error entirely? Or are you planning on keeping
compatibility with 0.17.x for a while?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
