zenfenan commented on PR #3367: URL: https://github.com/apache/avro/pull/3367#issuecomment-2949813937
@nandorKollar & @opwvhk Thanks for your reviews! I realised that you can actually have default value in your protobuf schema until proto2. It is only removed in proto3. Refer: - https://protobuf.dev/programming-guides/proto2/#enum-default - https://protobuf.dev/programming-guides/proto3/#enum-default So I updated the code to handle that, and also added a test (with new proto3 schema). Let me know if the commits need to be squashed into a single commit. BTW, the CodeQL violations are on the protobuf generated code. I couldn't find any exclusion config in the project. Let me know if this needs to be handled or not! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
