hmit commented on PR #3354: URL: https://github.com/apache/avro/pull/3354#issuecomment-2964539862
> META-INF/services/org.apache.avro.Conversion I went down this approach, however, found that ServiceLoader based setting applies to all instances of `ReflectData`. I intend it to apply to the default `INSTANCE` only and not any other instances created elsewhere. For eg: this test fails when moved to ServiceLoader - `TestTimeConversions.dynamicSchemaWithDateTimeMicrosConversion` I also think the `GenericData` class is correctly setup today with values preserved in their canonical type (and not logical type). I did try the change, however, and noticed that unit-tests like this one started failing - `TestGenericLogicalTypes.writeLocalTimestampMicros` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
