martin-g commented on PR #227: URL: https://github.com/apache/avro-rs/pull/227#issuecomment-3083845776
This won't work with the current version of avro-rs. With your PR the field is properly skipped, i.e. nothing is serialized for this field. But Avro's Reader uses the T::schema() to lead the deserialization of the data and wrongly reads the `y`'s value into `x` field and `z`'s value into `y`. For full roundtrip we will need a Serde-driven deserialization too. ser.rs and de.rs are Schema-driven impls. ser_schema.rs is Serde-driven serialization. We will need de_schema.rs (or some better names) for Serde-driven impl. @jdarais Do you agree with me here ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@avro.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
