Kriskras99 commented on code in PR #230:
URL: https://github.com/apache/avro-rs/pull/230#discussion_r2219077664
##########
avro/src/decimal.rs:
##########
@@ -93,7 +93,7 @@ impl Decimal {
let mut decimal_bytes = vec![sign_byte; len];
let raw_bytes = self.value.to_signed_bytes_be();
let num_raw_bytes = raw_bytes.len();
- let start_byte_index =
len.checked_sub(num_raw_bytes).ok_or(Error::SignExtend {
+ let start_byte_index =
len.checked_sub(num_raw_bytes).ok_or(Details::SignExtend {
Review Comment:
Because it's not a function call but just an enum construction it's not
necessary. Clippy even wants you to use `ok_or` if you're calling .len() on
something
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
