wgtmac commented on code in PR #3435: URL: https://github.com/apache/avro/pull/3435#discussion_r2255682684
########## lang/c++/CMakeLists.txt: ########## @@ -135,54 +137,64 @@ set (AVRO_SOURCE_FILES impl/CustomAttributes.cc ) -add_library (avrocpp SHARED ${AVRO_SOURCE_FILES}) -add_library (avrocpp_s STATIC ${AVRO_SOURCE_FILES}) - -target_compile_definitions(avrocpp PRIVATE AVRO_SOURCE AVRO_DYN_LINK) -target_compile_definitions(avrocpp_s PRIVATE AVRO_SOURCE) - -set_target_properties (avrocpp PROPERTIES VERSION ${AVRO_VERSION}) -set_target_properties (avrocpp_s PROPERTIES VERSION ${AVRO_VERSION}) - -target_link_libraries(avrocpp PUBLIC - $<BUILD_INTERFACE:fmt::fmt-header-only> - $<BUILD_INTERFACE:ZLIB::ZLIB> - $<BUILD_INTERFACE:$<TARGET_NAME_IF_EXISTS:Snappy::snappy>> - $<$<BOOL:${zstd_FOUND}>:$<BUILD_INTERFACE:$<TARGET_NAME_IF_EXISTS:${ZSTD_TARGET}>>> - $<BUILD_INTERFACE:$<TARGET_NAME_IF_EXISTS:Boost::system>> - $<INSTALL_INTERFACE:ZLIB::ZLIB> - $<INSTALL_INTERFACE:$<TARGET_NAME_IF_EXISTS:Snappy::snappy>> - $<$<BOOL:${zstd_FOUND}>:$<INSTALL_INTERFACE:$<TARGET_NAME_IF_EXISTS:${ZSTD_TARGET}>>> - $<INSTALL_INTERFACE:$<TARGET_NAME_IF_EXISTS:Boost::system>> -) -target_link_libraries(avrocpp_s PUBLIC - $<BUILD_INTERFACE:fmt::fmt-header-only> - $<BUILD_INTERFACE:ZLIB::ZLIB> - $<BUILD_INTERFACE:$<TARGET_NAME_IF_EXISTS:Snappy::snappy>> - $<$<BOOL:${zstd_FOUND}>:$<BUILD_INTERFACE:$<TARGET_NAME_IF_EXISTS:${ZSTD_TARGET}>>> - $<BUILD_INTERFACE:$<TARGET_NAME_IF_EXISTS:Boost::system>> - $<INSTALL_INTERFACE:ZLIB::ZLIB> - $<INSTALL_INTERFACE:$<TARGET_NAME_IF_EXISTS:Snappy::snappy>> - $<$<BOOL:${zstd_FOUND}>:$<INSTALL_INTERFACE:$<TARGET_NAME_IF_EXISTS:${ZSTD_TARGET}>>> - $<INSTALL_INTERFACE:$<TARGET_NAME_IF_EXISTS:Boost::system>> -) +set (AVRO_INSTALL_LIBS) + +if (AVRO_BUILD_SHARED) + add_library (avrocpp SHARED ${AVRO_SOURCE_FILES}) Review Comment: nit: perhaps we can create a function to include the common parts of both static and shared library to avoid duplicate modifications in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@avro.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org