wgtmac commented on code in PR #3479:
URL: https://github.com/apache/avro/pull/3479#discussion_r2323916220
##########
lang/c++/CMakeLists.txt:
##########
@@ -293,17 +294,28 @@ write_basic_package_version_file(
configure_package_config_file(
"${CMAKE_CURRENT_SOURCE_DIR}/cmake/AvroConfig.cmake.in"
"${CMAKE_CURRENT_BINARY_DIR}/AvroConfig.cmake"
- INSTALL_DESTINATION lib/cmake/Avro
+ INSTALL_DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/Avro
)
install(EXPORT avrocpp_targets
NAMESPACE Avro::
- DESTINATION lib/cmake/Avro
+ DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/Avro
FILE "AvroTargets.cmake"
)
install(FILES
"${CMAKE_CURRENT_BINARY_DIR}/AvroConfig.cmake"
"${CMAKE_CURRENT_BINARY_DIR}/AvroConfigVersion.cmake"
- DESTINATION lib/cmake/Avro
+ DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/Avro
Review Comment:
ditto
##########
lang/c++/CMakeLists.txt:
##########
@@ -293,17 +294,28 @@ write_basic_package_version_file(
configure_package_config_file(
"${CMAKE_CURRENT_SOURCE_DIR}/cmake/AvroConfig.cmake.in"
"${CMAKE_CURRENT_BINARY_DIR}/AvroConfig.cmake"
- INSTALL_DESTINATION lib/cmake/Avro
+ INSTALL_DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/Avro
Review Comment:
```suggestion
INSTALL_DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/avro-cpp
```
I think we just need to rebase on the latest main branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@avro.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
