Copilot commented on code in PR #3496:
URL: https://github.com/apache/avro/pull/3496#discussion_r2370322102
##########
lang/c++/test/StreamTests.cc:
##########
@@ -134,36 +135,34 @@ void testNonEmpty2(const TestData &td) {
Verify1()(*is, td.dataSize);
}
-static const char filename[] = "test_str.bin";
-
-struct FileRemover {
- const std::filesystem::path file;
- explicit FileRemover(const char *fn) : file(fn) {}
- ~FileRemover() { std::filesystem::remove(file); }
+struct FileGuard {
+ const std::filesystem::path path{ std::tmpnam(nullptr) };
Review Comment:
Using std::tmpnam(nullptr) is unsafe as it can cause race conditions and
security vulnerabilities. Consider using std::filesystem::temp_directory_path()
with a unique filename generator or platform-specific secure temporary file
functions instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
