mattiabasone commented on code in PR #3528:
URL: https://github.com/apache/avro/pull/3528#discussion_r2494012710
##########
lang/php/lib/Datum/AvroIOBinaryDecoder.php:
##########
@@ -164,120 +156,115 @@ public function readDouble()
* XXX: This is <b>not</b> endian-aware! See comments in
* {@link AvroIOBinaryEncoder::floatToIntBits()} for details.
*
- * @param string $bits
- * @returns float
*/
- public static function longBitsToDouble($bits)
+ public static function longBitsToDouble(string $bits)
{
$double = unpack('e', $bits);
- return (double) $double[1];
+ return (float) $double[1];
Review Comment:
`double` and `float` are the same thing in PHP, and `double` will be
deprecated soon
https://php.watch/versions/8.5/boolean-double-integer-binary-casts-deprecated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
