Kriskras99 commented on code in PR #339:
URL: https://github.com/apache/avro-rs/pull/339#discussion_r2598281685


##########
avro/src/schema.rs:
##########
@@ -2539,7 +2618,20 @@ pub mod derive {
     impl_schema!(f32, Schema::Float);
     impl_schema!(f64, Schema::Double);
     impl_schema!(String, Schema::String);
-    impl_schema!(uuid::Uuid, Schema::Uuid);
+    impl_schema!(
+        uuid::Uuid,
+        Schema::Uuid(UuidSchema::Fixed(FixedSchema {
+            name: Name {
+                name: String::new(),

Review Comment:
   That won't work, as we need the fixed size. I can either clone the name or 
add some documentation that anything created by this function should only exist 
temporarily (it's not a public function)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to