jdarais commented on code in PR #382:
URL: https://github.com/apache/avro-rs/pull/382#discussion_r2667150872
##########
avro/src/schema_equality.rs:
##########
@@ -165,6 +163,8 @@ impl SchemataEq for StructFieldEq {
) => {
self.compare(items_one, items_two)
}
+ (Schema::Duration(FixedSchema { size: size_one, ..}),
Schema::Duration(FixedSchema { size: size_two, ..})) => size_one == size_two,
+ (Schema::Duration(_), _) => false,
(Schema::Array(_), _) => false,
Review Comment:
I didn't realize I could commit these suggestions directly from the PR page.
I included these changes in my latest revision of the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
