opwvhk commented on code in PR #3614:
URL: https://github.com/apache/avro/pull/3614#discussion_r2667844417
##########
lang/java/gradle-plugin/src/main/kotlin/eu/eventloopsoftware/avro/gradle/plugin/extension/AvroGradlePluginExtension.kt:
##########
@@ -0,0 +1,226 @@
+package eu.eventloopsoftware.avro.gradle.plugin.extension
+
+import org.gradle.api.model.ObjectFactory
+import org.gradle.api.provider.ListProperty
+import org.gradle.api.provider.Property
+import javax.inject.Inject
+
+abstract class AvroGradlePluginExtension @Inject constructor(objects:
ObjectFactory) {
+
+ /**
+ * Schema type: "schema", "idl", "protocol" are valid. Default is "schema"
+ */
+ val schemaType: Property<String> =
objects.property(String::class.java).convention("schema")
+
+ /**
+ * The source directory of avro files. This directory is added to the
classpath
+ * at schema compiling time. All files can therefore be referenced as
classpath
+ * resources following the directory structure under the source directory.
+ *
+ * @parameter property="sourceDirectory"
Review Comment:
Can we use the Maven annotations instead? IMHO they're easier to read (less
likely to be missed when reading the code).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
