flxo commented on PR #439: URL: https://github.com/apache/avro-rs/pull/439#issuecomment-3799709038
> > * This change makes `write_avro_datum_ref` use `SchemAwareWriteSerializer` which is probably more expensive than a plain `write_avro_datum_ref`. Shall this be part of the MR? > > I don't understand the question. https://github.com/apache/avro-rs/pull/439/changes#diff-ceb4cd185f56c284ac854e0689daddc24c72649c7c791ebd09e934cb0c1049eaL733 - it was already using `SchemaAwareWriteSerializer::new(writer, schema, &names, None);` With your fix it uses the resolved `names`. This looks good to me! Thanks having a look. I'm not sure anymore why I wrote that - probably I looked at a wrong fn;. You're right that [write_avro_datum_ref](https://github.com/apache/avro-rs/blob/6218cd723a02e947c5d799065506a026c92388b5/avro/src/writer.rs#L731-L740) now just got proper `Names`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
