Kriskras99 commented on code in PR #447:
URL: https://github.com/apache/avro-rs/pull/447#discussion_r2735380487
##########
avro/src/writer.rs:
##########
@@ -195,9 +192,58 @@ impl<'a, W: Write> Writer<'a, W> {
/// internal buffering for performance reasons. If you want to be sure the
value has been
/// written, then call [`flush`](Writer::flush).
pub fn append_value_ref(&mut self, value: &Value) -> AvroResult<usize> {
+ if let Some(reason) = value.validate_internal(
+ self.schema,
+ self.resolved_schema.get_names(),
+ &self.schema.namespace(),
+ ) {
+ return Err(Details::ValidationWithReason {
+ value: value.clone(),
+ schema: self.schema.clone(),
+ reason,
+ }
+ .into());
+ }
+ self.unvalidated_append_value_ref(value)
+ }
+
+ /// Append a compatible value to a `Writer`.
+ ///
+ /// This function does **not** validate that the provided value matches
the schema. If it does
+ /// not match, the file will contain corrupt data. Use
[`Writer::append_value`] to have the
Review Comment:
I went with deprecating `append`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
