Kriskras99 commented on code in PR #448:
URL: https://github.com/apache/avro-rs/pull/448#discussion_r2745695730
##########
avro_derive/src/lib.rs:
##########
@@ -302,6 +328,41 @@ fn get_field_schema_expr(field: &Field, with: With) ->
Result<TokenStream, Vec<s
}
}
+fn get_field_get_record_fields_expr(
+ field: &Field,
+ with: With,
+) -> Result<TokenStream, Vec<syn::Error>> {
+ match with {
+ With::Trait => Ok(type_to_get_record_fields_expr(&field.ty)?),
+ With::Serde(path) => {
+ Ok(quote! { #path::get_record_fields_in_ctxt(named_schemas,
enclosing_namespace) })
Review Comment:
I've added the implementations. I really want to avoid people relying on the
default implementation, as it is really slow for records, so a compiler error
would be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
