PookieBuns commented on code in PR #458:
URL: https://github.com/apache/avro-rs/pull/458#discussion_r2791157971
##########
avro/src/serde/ser_schema.rs:
##########
@@ -1524,17 +1559,21 @@ impl<'s, W: Write> SchemaAwareWriteSerializer<'s, W> {
match schema {
Schema::Union(union_schema) => {
- let variant_schema = union_schema
- .schemas
- .get(variant_index as usize)
- .ok_or_else(|| {
- create_error(format!(
- "No variant schema at position {variant_index} for
{union_schema:?}"
- ))
- })?;
+ let branch_index = variant_index as usize +
usize::from(self.serializing_some);
+ if branch_index >= union_schema.schemas.len() {
+ return Err(create_error(format!(
+ "Variant index out of bounds: {}. The union schema has
'{}' schemas",
+ variant_index,
Review Comment:
Updated!
##########
avro/src/serde/ser_schema.rs:
##########
@@ -1835,17 +1878,17 @@ impl<'s, W: Write> SchemaAwareWriteSerializer<'s, W> {
match schema {
Schema::Union(union_schema) => {
- let variant_schema = union_schema
- .schemas
- .get(variant_index as usize)
- .ok_or_else(|| {
- create_error(format!(
- "Cannot find variant at position {variant_index}
in {union_schema:?}"
- ))
- })?;
+ let branch_index = variant_index as usize +
usize::from(self.serializing_some);
+ if branch_index >= union_schema.schemas.len() {
+ return Err(create_error(format!(
+ "Variant index out of bounds: {}. The union schema has
'{}' schemas",
+ variant_index,
Review Comment:
Updated!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
