martin-g commented on PR #472: URL: https://github.com/apache/avro-rs/pull/472#issuecomment-3927177906
> I think this would definitely be an improvement, but maybe better as a builder directly on `Schema`? According to https://bon-rs.com/guide/overview#method-builder only `#[builder]` on a method named `new()` will generate a `.build()` finish function. All others will generate `.call()`. > To get something like `Schema::array(array_schema).attributes(attr).build()`. But I think I can overwrite the finish_fn and rename `.call()` to `.build()`! I agree that it will be more "natural" for a Builder! Let me try it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
