gsson commented on issue #424: URL: https://github.com/apache/avro-rs/issues/424#issuecomment-3980344661
Very minor, but if I could make a wish, aligning the `darling` version with that of `bon`. Right now `bon` will select `darling` v0.23.0 and `avro_derive` will select v0.21.3 if given the chance. It's fine if not, but minimising duplicates would make my dependency closure easier to review :) [bon-macros](https://github.com/elastio/bon/blob/master/bon-macros/Cargo.toml) has this darling constraint from v3.8.2: ```toml # Darling `0.23` updated MSRV to `1.88+` without other code changes. # Therefore, it should be compatible with `0.22` as well. # # Version `0.20` is the version of `darling` available in Debian packages: # https://salsa.debian.org/rust-team/debcargo-conf. We keep support for it. darling = ">=0.20.0, <0.24.0" ``` This passes all tests and clippy: ```diff diff --git a/avro_derive/Cargo.toml b/avro_derive/Cargo.toml index 9ed7b2d..6059728 100644 --- a/avro_derive/Cargo.toml +++ b/avro_derive/Cargo.toml @@ -32,7 +32,7 @@ readme = "README.md" proc-macro = true [dependencies] -darling = { default-features = false, version = "0.21.3" } +darling = { default-features = false, version = "0.23.0" } proc-macro2 = { default-features = false, version = "1.0.106" } quote = { default-features = false, version = "1.0.44" } serde_json = { workspace = true } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
