Kriskras99 commented on code in PR #504: URL: https://github.com/apache/avro-rs/pull/504#discussion_r2889886999
########## avro_derive/tests/ui.rs: ########## @@ -18,7 +18,7 @@ /// These tests only run on nightly as the output can change per compiler version. /// /// See <https://github.com/dtolnay/trybuild/issues/84> -#[rustversion::attr(not(nightly), ignore)] +#[cfg_attr(not(msrv), ignore)] Review Comment: This does mean that a developer will have to install the MSRV to run the UI tests, I think it's more likely that developers will have nightly installed (or even enabled by default). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
