Kriskras99 commented on code in PR #501:
URL: https://github.com/apache/avro-rs/pull/501#discussion_r2891918172
##########
avro_derive/src/enums/plain.rs:
##########
@@ -46,15 +46,14 @@ pub fn schema_def(
};
symbols.push(name);
}
- let full_schema_name = &container_attrs.name;
Ok(quote! {
-
::apache_avro::schema::Schema::Enum(apache_avro::schema::EnumSchema {
- name:
::apache_avro::schema::Name::new(#full_schema_name).expect(&format!("Unable to
parse enum name for schema {}", #full_schema_name)[..]),
+
::apache_avro::schema::Schema::Enum(::apache_avro::schema::EnumSchema {
+ name,
Review Comment:
In my work on the schema generation for enums, I'm adding documentation to
all the functions on what variables they expect and what they output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
