Kriskras99 commented on code in PR #512:
URL: https://github.com/apache/avro-rs/pull/512#discussion_r3032114125
##########
avro/src/reader/single_object.rs:
##########
@@ -315,11 +354,11 @@ mod tests {
fn avro_rs_164_generic_reader_alternate_header() -> TestResult {
let schema_uuid =
Uuid::parse_str("b2f1cf00-0434-013e-439a-125eb8485a5f")?;
let header_builder = GlueSchemaUuidHeader::from_uuid(schema_uuid);
- let generic_reader =
GenericSingleObjectReader::new_with_header_builder(
- TestSingleObjectReader::get_schema(),
- header_builder,
- )
- .expect("failed to build reader");
+ let generic_reader = GenericSingleObjectReader::builder()
+ .schema(TestSingleObjectReader::get_schema())
+ .header(header_builder.build_header())
+ .build()
+ .expect("failed to build reader");
let data_to_read: Vec<u8> = vec![
3, 0, 178, 241, 207, 0, 4, 52, 1, 62, 67, 154, 18, 94, 184, 72,
90, 95,
];
Review Comment:
Adding a assert makes the test fail, I've reworked the test to actually test
being able to deserialize a value wih a different header format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
