splix commented on code in PR #530:
URL: https://github.com/apache/avro-rs/pull/530#discussion_r3038901781
##########
avro/src/reader/block.rs:
##########
@@ -156,6 +211,11 @@ impl<'r, R: Read> Block<'r, R> {
return Err(Details::GetBlockMarker.into());
}
+ self.current_block_info = Some(BlockPosition {
+ offset: block_start,
+ message_count: block_len as usize,
Review Comment:
I actually wrote this part specifically this way to ensure it would not
lost, if a refactoring or other change are applied. It cannot rely on the
meaning of the self.message_count and its current value if those two will be
separated into different places of code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
